Implement auto-open feature for browser launch on server start#276
Conversation
cliffhall
left a comment
cliffhall
left a comment
There was a problem hiding this comment.
I tested locally on Mac and it works ok, but a few things:
- There are conflicts to be resolved as the branch is behind.
- Yours launches with
http://localhostrather thanhttp://127.0.0.1which we're using instead, to comply with OAuth requirements. - Along with new config items comes a form field requirement in the sidebar. We need an affordance to turn this feature off.
cliffhall
added
enhancement
|
@cliffhall I've commited |
|
This is a double negative that made me have to think about its validity for a second. Could it instead be "Enable Browser Auto-open" and default to true? 
|
moeki0
force-pushed
the
auto_open
branch
3 times, most recently
from
77d4050 to
b09e982
Compare
|
@cliffhall Review please |
@kawakamidev It works fine for opening, but the UI configuration field doesn't change the behavior. If I set it to false then close the inspector, when I run the inspector again, it just auto launches. |
The problem here is that for this to work, the setting can't just be stored in the browser's local storage, it also has to write back to a locally stored configuration that will be consulted before the app launches next time. That's tough, since we don't currently have such a file and plumbing backwards from the client to write it would be a pain. Perhaps we should trim this back to the place you originally had it. Just the auto-open, no UI affordance. |
|
OK |
|
@cliffhall I have reverted the changes! |
cliffhall
left a comment
cliffhall
left a comment
There was a problem hiding this comment.
Just a suggestion for the README wording.
Co-authored-by: Cliff Hall <cliff@futurescale.com>
Implement auto-open feature for browser launch on server start
2 participants
Motivation and Context
This eliminates the manual step of copying URLs and opening browsers, making the development workflow more efficient.
How Has This Been Tested?
Tested on macOS environments with various browsers (Chrome, Firefox, Safari). Verified that the feature respects user configuration and can be disabled via configuration options.
Breaking Changes
No breaking changes. The feature is enabled by default but can be disabled through configuration.
Types of changes
Checklist